This is an automated email from the ASF dual-hosted git repository.

earthchen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git


The following commit(s) were added to refs/heads/master by this push:
     new 32434f1c valid tri upper header (#693)
32434f1c is described below

commit 32434f1c8e23e4bc04393cffd39990a048af7f88
Author: earthchen <[email protected]>
AuthorDate: Sat Feb 4 21:02:28 2023 +0800

    valid tri upper header (#693)
    
    * valid tri upper header
    
    * revert
    
    * ignore grpc
---
 .../java/org/apache/dubbo/sample/tri/stub/GreeterImpl.java    |  3 +++
 .../test/java/org/apache/dubbo/sample/tri/BaseClientTest.java | 11 +++++++++--
 .../apache/dubbo/sample/tri/grpc/TriGrpcDirectClientTest.java |  7 ++++++-
 3 files changed, 18 insertions(+), 3 deletions(-)

diff --git 
a/3-extensions/protocol/dubbo-samples-triple/src/main/java/org/apache/dubbo/sample/tri/stub/GreeterImpl.java
 
b/3-extensions/protocol/dubbo-samples-triple/src/main/java/org/apache/dubbo/sample/tri/stub/GreeterImpl.java
index 2c6fd0da..5b432598 100644
--- 
a/3-extensions/protocol/dubbo-samples-triple/src/main/java/org/apache/dubbo/sample/tri/stub/GreeterImpl.java
+++ 
b/3-extensions/protocol/dubbo-samples-triple/src/main/java/org/apache/dubbo/sample/tri/stub/GreeterImpl.java
@@ -51,8 +51,11 @@ public class GreeterImpl extends GreeterImplBase {
     @Override
     public GreeterReply greetWithAttachment(GreeterRequest request) {
         final String key = "user-attachment";
+        final String key2 = "Test";
         final String value = "hello," + 
RpcContext.getServerAttachment().getAttachment(key);
+        String value2 = RpcContext.getServerAttachment().getAttachment(key2);
         RpcContext.getServerContext().setObjectAttachment(key, value);
+        RpcContext.getServerContext().setObjectAttachment(key2, value2);
         return GreeterReply.newBuilder().setMessage("hello," + 
request.getName()).build();
     }
 
diff --git 
a/3-extensions/protocol/dubbo-samples-triple/src/test/java/org/apache/dubbo/sample/tri/BaseClientTest.java
 
b/3-extensions/protocol/dubbo-samples-triple/src/test/java/org/apache/dubbo/sample/tri/BaseClientTest.java
index 04aa200a..ee1072da 100644
--- 
a/3-extensions/protocol/dubbo-samples-triple/src/test/java/org/apache/dubbo/sample/tri/BaseClientTest.java
+++ 
b/3-extensions/protocol/dubbo-samples-triple/src/test/java/org/apache/dubbo/sample/tri/BaseClientTest.java
@@ -359,14 +359,21 @@ public abstract class BaseClientTest {
     @Test
     public void attachmentTest() {
         final String key = "user-attachment";
+        final String key2 = "Test";
+        final String value2 = "Value";
         final String value = "attachment-value";
         RpcContext.removeClientAttachment();
         RpcContext.getClientAttachment().setAttachment(key, value);
+        RpcContext.getClientAttachment().setAttachment(key2, value2);
         GreeterReply reply = delegate.greetWithAttachment(
                 GreeterRequest.newBuilder().setName("meta").build());
         Assert.assertEquals("hello,meta", reply.getMessage());
-        final String returned = (String) 
RpcContext.getServerContext().getObjectAttachment(key);
-        Assert.assertEquals("hello," + value, returned);
+        validUpperHeader(key2, value2);
+    }
+
+    protected void validUpperHeader(String key2, String value2) {
+        final String returned2 = (String) 
RpcContext.getServerContext().getObjectAttachment(key2);
+        Assert.assertEquals(value2, returned2);
     }
 
     @Test
diff --git 
a/3-extensions/protocol/dubbo-samples-triple/src/test/java/org/apache/dubbo/sample/tri/grpc/TriGrpcDirectClientTest.java
 
b/3-extensions/protocol/dubbo-samples-triple/src/test/java/org/apache/dubbo/sample/tri/grpc/TriGrpcDirectClientTest.java
index 3dccc09e..4c6b49b8 100644
--- 
a/3-extensions/protocol/dubbo-samples-triple/src/test/java/org/apache/dubbo/sample/tri/grpc/TriGrpcDirectClientTest.java
+++ 
b/3-extensions/protocol/dubbo-samples-triple/src/test/java/org/apache/dubbo/sample/tri/grpc/TriGrpcDirectClientTest.java
@@ -44,6 +44,11 @@ public class TriGrpcDirectClientTest extends BaseClientTest {
                 .reference(ref)
                 .start();
         delegate = ref.get();
-        appDubboBootstrap=bootstrap;
+        appDubboBootstrap = bootstrap;
+    }
+
+    @Override
+    protected void validUpperHeader(String key2, String value2) {
+        // grpc not support upper header
     }
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to