bobtthp commented on code in PR #2191:
URL: https://github.com/apache/dubbo-go/pull/2191#discussion_r1096940699
##########
registry/registry.go:
##########
@@ -64,6 +65,11 @@ type Registry interface {
// so sync load the instance of the preparing to subscribe service
before
// formally subscribing.
LoadSubscribeInstances(*common.URL, NotifyListener) error
+
+ // SubscribeURL is required to support the contract:
+ // 1. ServiceInstancesChangedListener provide by SubscribeURL
+ // 2. ServiceMappingChangedEvent provide by Subscribe
+ SubscribeURL(*common.URL, NotifyListener, *gxset.HashSet)
Review Comment:
so we can export ServiceDiscoveryRegistry struct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
