mytang0 commented on code in PR #11493:
URL: https://github.com/apache/dubbo/pull/11493#discussion_r1102517355
##########
dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/event/MetricsEventMulticaster.java:
##########
@@ -21,7 +21,11 @@
public interface MetricsEventMulticaster {
- void addListener(MetricsListener listener);
+ void addListener(MetricsListener<?> listener);
- void publishEvent(MetricsEvent event);
+ void publishEvent(MetricsEvent<?> event);
+
+ void publishFinishEvent(MetricsEvent<?> event);
Review Comment:
Why is the publish event split into 3 methods? Can it be distinguished by
MetricsEvent.Type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
