sadlay opened a new pull request, #11543:
URL: https://github.com/apache/dubbo/pull/11543

   ## What is the purpose of the change
   
   Fix 
[[#11524](https://github.com/apache/dubbo/issues/11524)](https://github.com/apache/dubbo/issues/11524)
   
   issue:
   Initiating RPC in the life cycle initialization phase of Spring Bean, that 
is, before ServiceBean#afterPropertiesSet, because configManager does not have 
any serviceConfig, and without publishing any provider, the 
DefaultApplicationDeployer#exportMetadataService() method is first triggered, 
resulting in org.apache.dubbo.metadata The .MetadataService metadata interface 
is exported first, and finally the url is passed and fixed in the 
ChannelHandler. After the service starts to receive the request, when obtaining 
the ExecutorService, the thread pool of the MetadataService is obtained through 
the url, not the thread pool configured by parameters such as 
dubbo.protocol.threads.
   
   solve:
   When the getExecutor(URL url) method obtains the thread pool, if it is the 
provider side and has a user-defined interface, the service thread pool will be 
used first to avoid using its own thread when the registered URL is 
org.apache.dubbo.metadata.MetadataService pool.
   
   ## Brief changelog
   
   
   ## Verifying this change
   
   
   <!-- Follow this checklist to help us incorporate your contribution quickly 
and easily: -->
   
   ## Checklist
   - [x] Make sure there is a 
[GitHub_issue](https://github.com/apache/dubbo/issues) field for the change 
(usually before you start working on it). Trivial changes like typos do not 
require a GitHub issue. Your pull request should address just this issue, 
without pulling in other changes - one PR resolves one issue.
   - [ ] Each commit in the pull request should have a meaningful subject line 
and body.
   - [ ] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
   - [ ] Write necessary unit-test to verify your logic correction, more mock a 
little better when cross module dependency exist. If the new feature or 
significant change is committed, please remember to add sample in [dubbo 
samples](https://github.com/apache/dubbo-samples) project.
   - [ ] Add some description to 
[dubbo-website](https://github.com/apache/dubbo-website) project if you are 
requesting to add a feature.
   - [ ] GitHub Actions works fine on your own branch.
   - [ ] If this contribution is large, please follow the [Software Donation 
Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to