zhaoyunxing92 commented on code in PR #2214:
URL: https://github.com/apache/dubbo-go/pull/2214#discussion_r1107937333
##########
config/service_config.go:
##########
@@ -331,13 +340,27 @@ func (s *ServiceConfig) Export() error {
return nil
}
-//setRegistrySubURL set registry sub url is ivkURl
+// getProtoParams get protocol params, convert to ProtocolParamsConfig
+func getProtoParams(params interface{}) *ProtocolParamsConfig {
Review Comment:
1. 初始化工作感觉放到这个地方比较合理
[protocol_config](https://github.com/apache/dubbo-go/blob/3.0/config/protocol_config.go#L45)
2. 感觉没有必要搞一个结构体，直接写到 protocol_config 就可以
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
