tiltwind commented on issue #348: URL: https://github.com/apache/dubbo-go-hessian2/issues/348#issuecomment-1434857822
@Penglq the hessian2 uses the api `time.UnixNano()`, but the year `2914` overflows for int64 for nanoseconds. From golang 1.17, it supports `time.UnixMilli()` api, which will fix this issue. But now the go version of the hessian ci used is 1.13, maybe we needs to upgrade the go version now. How do u think?@AlexStocks ```go // UnixNano returns t as a Unix time, the number of nanoseconds elapsed // since January 1, 1970 UTC. The result is undefined if the Unix time // in nanoseconds cannot be represented by an int64 (a date before the year // 1678 or after 2262). Note that this means the result of calling UnixNano // on the zero Time is undefined. The result does not depend on the // location associated with t. func (t Time) UnixNano() int64 { return (t.unixSec())*1e9 + int64(t.nsec()) } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org