sadlay commented on code in PR #11543:
URL: https://github.com/apache/dubbo/pull/11543#discussion_r1111681062
##########
dubbo-common/src/main/java/org/apache/dubbo/common/threadpool/manager/DefaultExecutorRepository.java:
##########
@@ -140,9 +141,21 @@ private ExecutorService createExecutor(URL url) {
return (ExecutorService)
extensionAccessor.getExtensionLoader(ThreadPool.class).getAdaptiveExtension().getExecutor(url);
}
+ private Map<Integer, ExecutorService> getExecutors(URL url) {
+ Map<Integer, ExecutorService> executors;
+ // if it's on the provider side and has user-defined services, use biz
service executor first, avoid using internal executor
+ if (PROVIDER_SIDE.equalsIgnoreCase(url.getParameter(SIDE_KEY))
+ && data.containsKey(EXECUTOR_SERVICE_COMPONENT_KEY)) {
+ executors = data.get(EXECUTOR_SERVICE_COMPONENT_KEY);
+ } else {
+ executors = data.get(getExecutorKey(url));
+ }
+ return executors;
+ }
+
Review Comment:
The `PortUnificationExchanger#reset` method will return a new url instead of
updating, so the Map in `AbstractPortUnificationServer#supportedUrls` will not
be changed.
in `NettyPortUnificationServerHandler#decode` , **localUrl** is set by the
value in **urlMapper**, not the updated **url**
So the url is still MetadataService.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
