songxiaosheng commented on code in PR #11632:
URL: https://github.com/apache/dubbo/pull/11632#discussion_r1118089525
##########
dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/model/MetricsKey.java:
##########
@@ -47,6 +47,9 @@ public enum MetricsKey {
METRIC_RT_P99("dubbo.%s.rt.seconds.p99", "Response Time P99"),
METRIC_RT_P95("dubbo.%s.rt.seconds.p95", "Response Time P95"),
+ PROVIDER_METRIC_RT_HISTOGRAM("dubbo.%s.rt.seconds.histogram", "Response
Time Histogram"),
Review Comment:
please change the name of PROVIDEER_METRIC_RT_HISTORYGRAM to
METRIC_RT_HISTORYGRAM
seconds may be error , need change to milliseconds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
