icodening commented on code in PR #11698:
URL: https://github.com/apache/dubbo/pull/11698#discussion_r1124087114


##########
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/command/QueuedCommand.java:
##########
@@ -41,7 +41,13 @@ public void cancel() {
 
     public void run(Channel channel) {
         if (channel.isActive()) {
-            channel.write(this, promise);
+            channel.write(this).addListener(future -> {

Review Comment:
   The stream channel has not been constructed when the header/data is sent, 
the `ChannelPromise` of header/data comes from the `parent channel`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

Reply via email to