justxuewei commented on code in PR #2238:
URL: https://github.com/apache/dubbo-go/pull/2238#discussion_r1127261979
##########
registry/polaris/service_discovery.go:
##########
@@ -317,17 +317,20 @@ func (polaris *polarisServiceDiscovery) String() string {
func convertToRegisterInstance(namespace string, instance
registry.ServiceInstance) *api.InstanceRegisterRequest {
- health := instance.IsHealthy()
- isolate := instance.IsEnable()
- ttl := 5
+ var (
+ health = instance.IsHealthy()
+ isolate = instance.IsEnable()
+ ttl = 5
+ protocolVal = protocolForDubboGO
Review Comment:
What is meaning of `protocolForDubboGO`? If it is refering to the Dubbo
procotol, I would suggest using either `const.Dubbo` or
`const.DefaultProtocol`, please refer to
[const](https://github.com/apache/dubbo-go/blob/3.1/common/constant/default.go).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
