justxuewei commented on code in PR #2246:
URL: https://github.com/apache/dubbo-go/pull/2246#discussion_r1136574101
##########
config/protocol_config.go:
##########
@@ -31,6 +31,9 @@ type ProtocolConfig struct {
Ip string `yaml:"ip" json:"ip,omitempty" property:"ip"`
Port string `default:"20000" yaml:"port" json:"port,omitempty"
property:"port"`
Params interface{} `yaml:"params" json:"params,omitempty"
property:"params"`
+
+ MaxServerSendMsgSize string `yaml:"max-server-send-msg-size"
json:"max-server-send-msg-size,omitempty"`
Review Comment:
Please add a comment for its unit, like "1mib=1024b, 1mb=1000b", or "Please
refer to go-humanize package for its unit.".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
