dengWuuu commented on code in PR #11798:
URL: https://github.com/apache/dubbo/pull/11798#discussion_r1138790264
##########
dubbo-metrics/dubbo-metrics-metadata/src/test/java/org/apache/dubbo/metrics/metadata/MetadataStatCompositeTest.java:
##########
@@ -37,8 +37,8 @@ public class MetadataStatCompositeTest {
void testInit() {
MetadataStatComposite statComposite = new MetadataStatComposite();
Assertions.assertEquals(statComposite.numStats.size(),
MetadataEvent.Type.values().length);
- //(rt)5 * (push,subscribe)2
- Assertions.assertEquals(5 * 2, statComposite.rtStats.size());
+ //(rt)5 * (push,subscribe,store provider)2
Review Comment:
> Shouldn't the assertion here be 5*4
storeProvider is one but not store provider
i will change the comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
