ShawnHXH commented on code in PR #548:
URL: https://github.com/apache/dubbo-go-pixiu/pull/548#discussion_r1141277128
##########
pixiu/pkg/client/triple/triple.go:
##########
@@ -68,40 +76,47 @@ func (tc *Client) MapParams(req *client.Request) (reqData
interface{}, err error
}
// Close clear GenericServicePool.
-func (dc *Client) Close() error {
+func (tc *Client) Close() error {
return nil
}
// SingletonTripleClient singleton dubbo clent
-func SingletonTripleClient() *Client {
- return NewTripleClient()
+func SingletonTripleClient(protoset []string) *Client {
+ return NewTripleClient(protoset)
}
// Call invoke service
-func (dc *Client) Call(req *client.Request) (res interface{}, err error) {
+func (tc *Client) Call(req *client.Request) (res interface{}, err error) {
address :=
strings.Split(req.API.IntegrationRequest.HTTPBackendConfig.URL, ":")
- p := proxy.NewProxy()
+ p := proxy.NewProxy(tc.protosetSource)
Review Comment:
sure, singleton works even better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
