justxuewei commented on code in PR #2267:
URL: https://github.com/apache/dubbo-go/pull/2267#discussion_r1156800954
##########
common/url.go:
##########
@@ -438,6 +438,18 @@ func ParseServiceKey(serviceKey string) (string, string,
string) {
return serviceKey, group, version
}
+// IsAnyCondition judges if is any condition
+func IsAnyCondition(subscribedKey string, subscribedURL, serviceURL *URL) bool
{
Review Comment:
The parameters are too confusing. In my opinion, it should be: func
IsAnyCondition(intf, group, version string) bool. How to get those keys is none
of the business of this method. In other words, this method focuses on
determining whether it is an "any condition."
##########
common/url.go:
##########
@@ -438,6 +438,18 @@ func ParseServiceKey(serviceKey string) (string, string,
string) {
return serviceKey, group, version
}
+// IsAnyCondition judges if is any condition
+func IsAnyCondition(subscribedKey string, subscribedURL, serviceURL *URL) bool
{
Review Comment:
The parameters are too confusing. In my opinion, it should be: `func
IsAnyCondition(intf, group, version string) bool`. How to get those keys is
none of the business of this method. In other words, this method focuses on
determining whether it is an "any condition."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
