AlbumenJ commented on code in PR #11987:
URL: https://github.com/apache/dubbo/pull/11987#discussion_r1158072101
##########
dubbo-common/src/test/java/org/apache/dubbo/common/utils/ConcurrentHashMapUtilsTest.java:
##########
@@ -37,4 +37,17 @@ public void testComputeIfAbsent() {
ifAbsent = ConcurrentHashMapUtils.computeIfAbsent(map, "mxsm", k ->
"mxsm1");
assertEquals("mxsm1", ifAbsent);
}
+
+ @Test
+ public void issue11986Test(){
+ // https://github.com/apache/dubbo/issues/11986
+ final ConcurrentHashMap<String,Integer> map=new ConcurrentHashMap<>();
+ // // map.computeIfAbsent("AaAa",
key->map.computeIfAbsent("BBBB",key2->42));
+ if (JRE.JAVA_8.isCurrentVersion()) {
Review Comment:
那基于 junit5 的注解做两个测试吧
现在 PR的 UT 只跑 JDK17，JDK 8 11 17 的全量测试只有 scheduled 的时候跑
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
