aamingaa commented on code in PR #11975:
URL: https://github.com/apache/dubbo/pull/11975#discussion_r1159230133
##########
dubbo-remoting/dubbo-remoting-netty/src/test/java/org/apache/dubbo/remoting/exchange/support/header/HeartbeatHandlerTest.java:
##########
@@ -118,6 +131,11 @@ void testClientHeartbeat() throws Exception {
.addParameter(Constants.EXCHANGER_KEY, HeaderExchanger.NAME)
.addParameter(Constants.TRANSPORTER_KEY, "netty3")
.addParameter(Constants.CODEC_KEY, "telnet");
+ ApplicationModel applicationModel = ApplicationModel.defaultModel();
Review Comment:
duplicate with line 108 ～ 112？
##########
dubbo-common/src/main/java/org/apache/dubbo/rpc/executor/AbstractIsolationExecutorSupport.java:
##########
@@ -50,15 +50,17 @@ public Executor getExecutor(Object data) {
for (URL serviceUrl : serviceUrls) {
if (serviceUrl.getProtocol().equals(url.getProtocol()) &&
serviceUrl.getPort() == url.getPort()) {
- return executorRepository.getExecutor(serviceUrl);
+ return executorRepository.getExecutor(providerModel,
serviceUrl);
}
}
- return executorRepository.getExecutor(serviceUrls.get(0));
+ return executorRepository.getExecutor(providerModel,
serviceUrls.get(0));
}
- protected abstract ServiceKey getServiceKey(Object data);
+ protected ServiceKey getServiceKey(Object data) {
Review Comment:
why change this method from abstract ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
