icodening commented on code in PR #12021:
URL: https://github.com/apache/dubbo/pull/12021#discussion_r1159314852
##########
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java:
##########
@@ -129,15 +129,14 @@ public void configServerProtocolHandler(URL url,
ChannelOperator operator) {
.build();
ExecutorSupport executorSupport =
ExecutorRepository.getInstance(url.getOrDefaultApplicationModel()).getExecutorSupport(url);
codec.connection().local().flowController().frameWriter(codec.encoder().frameWriter());
- TripleWriteQueue writeQueue = new TripleWriteQueue();
final Http2MultiplexHandler handler = new Http2MultiplexHandler(
new ChannelInitializer<Http2StreamChannel>() {
@Override
protected void initChannel(Http2StreamChannel ch) {
final ChannelPipeline p = ch.pipeline();
p.addLast(new TripleCommandOutBoundHandler());
p.addLast(new
TripleHttp2FrameServerHandler(frameworkModel, executorSupport,
- headFilters, ch, writeQueue));
+ headFilters, ch, new TripleWriteQueue(ch)));
Review Comment:
performance optimize fails. ref PR #10587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
