EarthChen commented on code in PR #12026:
URL: https://github.com/apache/dubbo/pull/12026#discussion_r1159782566
##########
dubbo-rpc/dubbo-rpc-triple/pom.xml:
##########
@@ -92,6 +92,11 @@
<version>${reactor.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
Introducing register at the protocol layer doesn't seem like a good idea.
Can we wrapper MetadataService directly? Repeating implementation logic is
not good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
