AlexStocks commented on code in PR #2314:
URL: https://github.com/apache/dubbo-go/pull/2314#discussion_r1194729514
##########
remoting/zookeeper/listener.go:
##########
@@ -344,8 +344,7 @@ func (l *ZkEventListener) listenDirEvent(conf *common.URL,
zkRootPath string, li
failTimes = MaxFailTimes
}
- err = perrors.Cause(err)
- if !strings.Contains(err.Error(), "node does not
exist") { // ignore if node not exist
+ if !perrors.Is(err, zk.ErrNoNode) { // ignore if node
not exist
Review Comment:
@chickenlj 这个地方我有异议，这个地方不需要修改啊，原来的没啥问题。你修改后，会不会遗漏一些case就不晓得了。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
