wxbty commented on PR #12329: URL: https://github.com/apache/dubbo/pull/12329#issuecomment-1551333720
> >  > > How about cache in AbstractMetricsListener. > > Allocate a map to cache class is not a good idea, and this may cause classloader unable to being gc. > > @AlbumenJ Good idea, Is this ok?  > > Tested to improve performance by 2% than cache in ReflectionUtils Would it be better to put the match method in util, and use Object for the event type? It is not the responsibility of the current class -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
