justxuewei commented on code in PR #2306:
URL: https://github.com/apache/dubbo-go/pull/2306#discussion_r1198937836
##########
registry/directory/directory.go:
##########
@@ -90,9 +90,9 @@ func NewRegistryDirectory(url *common.URL, registry
registry.Registry) (director
logger.Warnf("fail to create router chain with url: %s, err is:
%v", url.SubURL, err)
}
- dir.consumerConfigurationListener =
newConsumerConfigurationListener(dir)
- dir.consumerConfigurationListener.addNotifyListener(dir)
- dir.referenceConfigurationListener =
newReferenceConfigurationListener(dir, url)
+ //dir.consumerConfigurationListener =
newConsumerConfigurationListener(dir)
Review Comment:
Add a `FIXME` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
