songxiaosheng commented on code in PR #12273: URL: https://github.com/apache/dubbo/pull/12273#discussion_r1201518031
########## dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/command/impl/DefaultMetricsReporterCmd.java: ########## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.dubbo.qos.command.impl; + +import org.apache.dubbo.common.utils.JsonUtils; +import org.apache.dubbo.metrics.report.MetricsReporter; +import org.apache.dubbo.qos.api.BaseCommand; +import org.apache.dubbo.qos.api.Cmd; +import org.apache.dubbo.qos.api.CommandContext; +import org.apache.dubbo.rpc.model.ApplicationModel; +import org.apache.dubbo.rpc.model.FrameworkModel; + +import java.io.CharArrayReader; +import java.io.IOException; +import java.io.LineNumberReader; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Optional; + +@Cmd(name = "metrics_default", summary = "reuse qos report") Review Comment: Please use the descriptive information of 'see name and know meaning' <img width="594" alt="image" src="https://github.com/apache/dubbo/assets/81170548/dfd3fac1-c954-4989-948a-10f39e6c7904";> ########## dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/command/impl/DefaultMetricsReporterCmd.java: ########## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.dubbo.qos.command.impl; + +import org.apache.dubbo.common.utils.JsonUtils; +import org.apache.dubbo.metrics.report.MetricsReporter; +import org.apache.dubbo.qos.api.BaseCommand; +import org.apache.dubbo.qos.api.Cmd; +import org.apache.dubbo.qos.api.CommandContext; +import org.apache.dubbo.rpc.model.ApplicationModel; +import org.apache.dubbo.rpc.model.FrameworkModel; + +import java.io.CharArrayReader; +import java.io.IOException; +import java.io.LineNumberReader; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Optional; + +@Cmd(name = "metrics_default", summary = "reuse qos report") +public class DefaultMetricsReporterCmd implements BaseCommand { + + public FrameworkModel frameworkModel; + + public DefaultMetricsReporterCmd(FrameworkModel frameworkModel) { + this.frameworkModel = frameworkModel; + } + + @Override + public String execute(CommandContext commandContext, String[] args) { + List<ApplicationModel> models = frameworkModel.getApplicationModels(); + String result = "There is no application with data"; + if (notSpecifyApplication(args)) { + result = useFirst(models, result, null); + } else if (args.length == 1) { + result = specifyApplication(args[0], models, null); + } else if (args.length == 2) { + result = specifyApplication(args[0], models, args[1]); + } + return result; + } + + private boolean notSpecifyApplication(String[] args) { + return args == null || args.length == 0; + } + + private String useFirst(List<ApplicationModel> models, String result, String metricsName) { + for (ApplicationModel model : models) { + String current = getResponseByApplication(model, metricsName); + if (getLineNumber(current) > 0) { + result = current; + break; + } + } + return result; + } + + private String specifyApplication(String appName, List<ApplicationModel> models, String metricsName) { + if ("application_all".equals(appName)) { + return allApplication(models); + } else { + return specifySingleApplication(appName, models, metricsName); + } + } + + private String specifySingleApplication(String appName, List<ApplicationModel> models, String metricsName) { + Optional<ApplicationModel> modelOptional = models.stream() + .filter(applicationModel -> appName.equals(applicationModel.getApplicationName())).findFirst(); + if (modelOptional.isPresent()) { + return getResponseByApplication(modelOptional.get(), metricsName); + } else { + return "Not exist application: " + appName; + } + } + + private String allApplication(List<ApplicationModel> models) { + Map<String, String> appResultMap = new HashMap<>(); + for (ApplicationModel model : models) { + appResultMap.put(model.getApplicationName(), getResponseByApplication(model, null)); + } + return JsonUtils.toJson(appResultMap); + } + + private String getResponseByApplication(ApplicationModel applicationModel, String metricsName) { + String response = "MetricsReporter not init"; + MetricsReporter metricsReporter = applicationModel.getBeanFactory().getBean(MetricsReporter.class); + if (metricsReporter != null) { + metricsReporter.refreshData(); + response = metricsReporter.getResponseWithName(metricsName); + } + return response; + } + + + private static long getLineNumber(String content) { + LineNumberReader lnr = new LineNumberReader(new CharArrayReader(content.toCharArray())); Review Comment: please fix NullPointException <img width="1178" alt="image" src="https://github.com/apache/dubbo/assets/81170548/f8845a5c-8444-478f-9020-6e7728c2b3b3";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
