[GitHub] [dubbo] finefuture commented on a diff in pull request #12389: add metrics enable switch

[via GitHub]

finefuture commented on code in PR #12389:
URL: https://github.com/apache/dubbo/pull/12389#discussion_r1214027657


##########
dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/AbstractConfigTest.java:
##########
@@ -1002,7 +1002,7 @@ void testMetaData() throws Exception {
         List<Class<? extends AbstractConfig>> configClasses = 
Arrays.asList(ApplicationConfig.class,
                 ConsumerConfig.class, ProviderConfig.class, 
ReferenceConfig.class, ServiceConfig.class,
                 ProtocolConfig.class, RegistryConfig.class, 
ConfigCenterConfig.class, MetadataReportConfig.class,
-                ModuleConfig.class, SslConfig.class, MetricsConfig.class, 
MonitorConfig.class, MethodConfig.class);
+                ModuleConfig.class, SslConfig.class, MonitorConfig.class, 
MethodConfig.class);

Review Comment:
   Because the property enableRpc of MetricsConfig is set to true, the metadata 
won't be empty
   
![image](https://github.com/apache/dubbo/assets/18413695/29f552c5-b1e1-49ed-97bb-93165cc7d301)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org