AlexStocks commented on code in PR #2338:
URL: https://github.com/apache/dubbo-go/pull/2338#discussion_r1229358501
##########
cluster/router/tag/router.go:
##########
@@ -58,7 +58,7 @@ func (p *PriorityRouter) Route(invokers []protocol.Invoker,
url *common.URL, inv
return staticTag(invokers, url, invocation)
}
routerCfg := value.(config.RouterConfig)
Review Comment:
routerCfg1, ok1 := value.(config.RouterConfig)
routerCfg, ok = value.(*config.RouterConfig)
if !ok1 && !ok {
xxxx
return
}
if ok1 {
routerCfg = &routerCfg1
}
最根本原因是这里判断是否为空没做好，而不是下面加上指针调用
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
