finefuture commented on code in PR #12547:
URL: https://github.com/apache/dubbo/pull/12547#discussion_r1233493343
##########
dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/event/listener/ServiceInstancesChangedListener.java:
##########
@@ -473,12 +467,12 @@ public boolean equals(Object o) {
return false;
}
ServiceInstancesChangedListener that =
(ServiceInstancesChangedListener) o;
- return Objects.equals(getServiceNames(), that.getServiceNames()) &&
Objects.equals(listeners, that.listeners);
+ return Objects.equals(getServiceNames(), that.getServiceNames());
Review Comment:
@AlbumenJ Should the listeners parameter be retained in equals, or should we
use the ApplicationModel to determine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
