AlbumenJ commented on PR #12655: URL: https://github.com/apache/dubbo/pull/12655#issuecomment-1649833530
> > It would be better to rename `requestBeforeEvent` to `requestErrorEvent` > > > It would be better to rename `requestBeforeEvent` to `requestErrorEvent` > > The focus of this event is that the request was aborted before execution, so I think requestBeforeEvent is more appropriate. Do you think so However there are only one event in the case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
