xieshouyu opened a new pull request, #12796: URL: https://github.com/apache/dubbo/pull/12796
## What is the purpose of the change When the zookeeper is disconnected, the dubbo actor check registry health will be stuck instead of returning to Down I hope the result is to return to the Down state The reason is that the isAvailable method calls the getServices method of zookeeper, causing continuous retries. When determining whether it is available, it is necessary to first determine whether it is connected before obtaining it. ## Brief changelog 1、Fix the issue of timeout for all calls to the isAvailable method after the zookeeper is disconnected 2、Move the isAvailable of NopServiceDiscovery into its own implementation class ## Verifying this change Start the service, use pfctl or iptables to disconnect zookeeper, and it can return to the down state normally. <!-- Follow this checklist to help us incorporate your contribution quickly and easily: --> ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7 - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature. - [ ] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
