EarthChen commented on code in PR #12815: URL: https://github.com/apache/dubbo/pull/12815#discussion_r1281629736
########## dubbo-remoting/dubbo-remoting-http12/src/main/java/org/apache/dubbo/remoting/http12/netty4/h1/NettyHttp1ConnectionHandler.java: ########## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.dubbo.remoting.http12.netty4.h1; + +import io.netty.channel.ChannelHandlerContext; +import io.netty.channel.SimpleChannelInboundHandler; +import org.apache.dubbo.common.URL; +import org.apache.dubbo.common.threadpool.ThreadPool; +import org.apache.dubbo.common.utils.Assert; +import org.apache.dubbo.remoting.http12.h1.Http1Request; +import org.apache.dubbo.remoting.http12.h1.Http1ServerChannelObserver; +import org.apache.dubbo.remoting.http12.h1.Http1ServerTransportListener; +import org.apache.dubbo.remoting.http12.h1.Http1ServerTransportListenerFactory; +import org.apache.dubbo.remoting.http12.message.JsonCodec; +import org.apache.dubbo.rpc.model.FrameworkModel; + +import java.util.concurrent.Executor; + +public class NettyHttp1ConnectionHandler extends SimpleChannelInboundHandler<Http1Request> { + + private Http1ServerTransportListenerFactory http1ServerTransportListenerFactory; + + private Http1ServerTransportListener http1TransportListener; + + private final FrameworkModel frameworkModel; + + private final URL url; + + private final Executor executor; + + private Http1ServerChannelObserver errorResponseObserver; + + public NettyHttp1ConnectionHandler(URL url, FrameworkModel frameworkModel) { + this.url = url; + this.frameworkModel = frameworkModel; + this.executor = url.getOrDefaultFrameworkModel().getExtensionLoader(ThreadPool.class).getAdaptiveExtension().getExecutor(url); + } + + public NettyHttp1ConnectionHandler(URL url, + FrameworkModel frameworkModel, + Http1ServerTransportListenerFactory http1ServerTransportListenerFactory) { + this.url = url; + this.frameworkModel = frameworkModel; + this.executor = url.getOrDefaultFrameworkModel().getExtensionLoader(ThreadPool.class).getAdaptiveExtension().getExecutor(url); + this.http1ServerTransportListenerFactory = http1ServerTransportListenerFactory; + } + + public void setHttp1ServerTransportListenerFactory(Http1ServerTransportListenerFactory http1ServerTransportListenerFactory) { + this.http1ServerTransportListenerFactory = http1ServerTransportListenerFactory; + } + + protected void channelRead0(ChannelHandlerContext ctx, Http1Request http1Request) { + //process h1 request + initTransportListenerIfNecessary(ctx); + executor.execute(() -> { + try { + http1TransportListener.onMetadata(http1Request); + http1TransportListener.onData(http1Request); + } catch (Exception e) { + errorResponseObserver.onError(e); + } + }); + } + + private void initTransportListenerIfNecessary(ChannelHandlerContext ctx) { + if (http1TransportListener == null) { + Http1ServerTransportListenerFactory http1ServerTransportListenerFactory = this.http1ServerTransportListenerFactory; + Assert.notNull(http1ServerTransportListenerFactory, "http1ServerTransportListenerFactory must be not null."); + http1TransportListener = http1ServerTransportListenerFactory.newInstance(new NettyHttp1Channel(ctx.channel()), url, frameworkModel); + } + this.errorResponseObserver = new Http1ServerChannelObserver(new NettyHttp1Channel(ctx.channel())); + this.errorResponseObserver.setHttpMessageCodec(JsonCodec.INSTANCE); Review Comment: The json should not be written dead here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
