Lvnszn commented on code in PR #2369:
URL: https://github.com/apache/dubbo-go/pull/2369#discussion_r1288001256
##########
registry/servicediscovery/service_mapping_change_listener_impl.go:
##########
@@ -63,6 +65,9 @@ func (lstn *ServiceMappingChangedListenerImpl) OnEvent(e
observer.Event) error {
err error
reg registry.Registry
)
+
+ lstn.mux.Lock()
Review Comment:
这个加锁之后中间 return 没有 unlock
##########
registry/servicediscovery/service_mapping_change_listener_impl.go:
##########
@@ -63,6 +65,9 @@ func (lstn *ServiceMappingChangedListenerImpl) OnEvent(e
observer.Event) error {
err error
reg registry.Registry
)
+
+ lstn.mux.Lock()
Review Comment:
这个加锁之后中间 return 没有 unlock
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
