[GitHub] [dubbo-go] Lvnszn commented on a diff in pull request #2330: Improve tag and configurator rules to keep up with official site

[via GitHub]

Lvnszn commented on code in PR #2330:
URL: https://github.com/apache/dubbo-go/pull/2330#discussion_r1287995062


##########
config/router_config.go:
##########
@@ -18,6 +18,7 @@
 package config
 
 import (
+       "dubbo.apache.org/dubbo-go/v3/common"
        "github.com/creasty/defaults"

Review Comment:
   import fmt



##########
config_center/configurator/override.go:
##########
@@ -18,6 +18,7 @@
 package configurator
 
 import (
+       "dubbo.apache.org/dubbo-go/v3/config_center/parser"

Review Comment:
   同上



##########
registry/base_configuration_listener.go:
##########
@@ -69,7 +69,7 @@ func (bcl *BaseConfigurationListener) InitWith(key string, 
listener config_cente
 
 // Process the notification event once there's any change happens on the 
config.
 func (bcl *BaseConfigurationListener) Process(event 
*config_center.ConfigChangeEvent) {
-       logger.Debugf("Notification of overriding rule, change type is: %v , 
raw config content is:%v", event.ConfigType, event.Value)
+       logger.Infof("Notification of overriding rule, change type is: %v , raw 
config content is:%v", event.ConfigType, event.Value)

Review Comment:
   这个日志打印会更多，可能会占用更多IO，需要打开么？



##########
config_center/configurator/override.go:
##########
@@ -18,6 +18,7 @@
 package configurator
 
 import (
+       "dubbo.apache.org/dubbo-go/v3/config_center/parser"

Review Comment:
   同上



##########
registry/base_configuration_listener.go:
##########
@@ -69,7 +69,7 @@ func (bcl *BaseConfigurationListener) InitWith(key string, 
listener config_cente
 
 // Process the notification event once there's any change happens on the 
config.
 func (bcl *BaseConfigurationListener) Process(event 
*config_center.ConfigChangeEvent) {
-       logger.Debugf("Notification of overriding rule, change type is: %v , 
raw config content is:%v", event.ConfigType, event.Value)
+       logger.Infof("Notification of overriding rule, change type is: %v , raw 
config content is:%v", event.ConfigType, event.Value)

Review Comment:
   这个日志打印会更多，可能会占用更多IO，需要打开么？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org