AlbumenJ commented on code in PR #12879:
URL: https://github.com/apache/dubbo/pull/12879#discussion_r1291329702
##########
dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java:
##########
@@ -265,6 +266,12 @@ Invoker<?> getInvoker(Channel channel, Invocation inv)
throws RemotingException
int port = channel.getLocalAddress().getPort();
String path = (String) inv.getObjectAttachmentWithoutConvert(PATH_KEY);
+ // if the environment variable DUBBO_PORT_TO_REGISTRY is added
+ String dubboPortToRegistry =
ConfigUtils.getSystemProperty(org.apache.dubbo.config.Constants.DUBBO_PORT_TO_REGISTRY);
+ if(StringUtils.isNotEmpty(dubboPortToRegistry)) {
+ port = Integer.valueOf(dubboPortToRegistry);
Review Comment:
As for https://github.com/apache/dubbo/issues/12798, it is recommended to
use `dubbo.protocol.port` insteand of `DUBBO_PORT_TO_REGISTRY`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
