wxbty commented on code in PR #12888:
URL: https://github.com/apache/dubbo/pull/12888#discussion_r1294474451
##########
dubbo-metrics/dubbo-metrics-event/src/main/java/org/apache/dubbo/metrics/event/MetricsEvent.java:
##########
@@ -32,21 +32,21 @@
public abstract class MetricsEvent {
/**
- * Metric object. (eg. {@link MethodMetric})
+ * Metric object. (eg. MethodMetric)
*/
protected transient final ApplicationModel source;
private boolean available = true;
private final TypeWrapper typeWrapper;
private final String appName;
- private final MetricsDispatcher metricsDispatcher;
+ private final MetricsEventMulticaster MetricsEventMulticaster;
private final Map<String, Object> attachment = new IdentityHashMap<>(8);
public MetricsEvent(ApplicationModel source, TypeWrapper typeWrapper) {
this(source, null, null, typeWrapper);
}
- public MetricsEvent(ApplicationModel source, String appName,
MetricsDispatcher metricsDispatcher, TypeWrapper typeWrapper) {
+ public MetricsEvent(ApplicationModel source, String appName,
MetricsEventMulticaster MetricsEventMulticaster, TypeWrapper typeWrapper) {
Review Comment:
Please follow the naming convention
##########
dubbo-metrics/dubbo-metrics-metadata/src/test/java/org/apache/dubbo/metrics/metadata/MetadataMetricsCollectorTest.java:
##########
@@ -62,7 +63,7 @@ public void setup() {
config.setName("MockMetrics");
applicationModel.getApplicationConfigManager().setApplication(config);
-
applicationModel.getBeanFactory().getOrRegisterBean(MetricsDispatcher.class);
+
applicationModel.getBeanFactory().getOrRegisterBean(MetricsConstants.METRICS_DISPATCHER_NAME,MetricsDispatcher.class);
Review Comment:
Is there any purpose to name the bean registered by MetricsDispatcher
separately? As far as I understand, this bean is unique
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
