wxbty commented on code in PR #12892:
URL: https://github.com/apache/dubbo/pull/12892#discussion_r1306393891
##########
dubbo-metrics/dubbo-metrics-default/src/main/java/org/apache/dubbo/metrics/event/DefaultSubDispatcher.java:
##########
@@ -69,7 +70,7 @@ private CategoryOverall initMethodRequest() {
MetricsSupport.increment(key, dynamicPlaceType,
(MethodMetricsCollector) collector, event);
MetricsSupport.increment(MetricsKey.METRIC_REQUESTS_PROCESSING,
dynamicPlaceType, (MethodMetricsCollector) collector, event);
})),
- new MetricsCat(MetricsKey.METRIC_REQUESTS_SUCCEED, (key,
placeType, collector) -> AbstractMetricsKeyListener.onFinish(key,
+ new MetricsCat(METRIC_REQUESTS_SUCCEED, (key, placeType,
collector) -> AbstractMetricsKeyListener.onFinish(key,
Review Comment:
Don't change that. Keep it the same as before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
