chickenlj commented on code in PR #2374:
URL: https://github.com/apache/dubbo-go/pull/2374#discussion_r1306852639
##########
registry/nacos/registry.go:
##########
@@ -169,36 +169,95 @@ func (nr *nacosRegistry) Subscribe(url *common.URL,
notifyListener registry.Noti
if role != common.CONSUMER {
return nil
}
+ serviceName := getServiceName(url)
+ if serviceName == "*" {
+ // Subscribe to all services
+ for {
+ if !nr.IsAvailable() {
+ logger.Warnf("event listener game over.")
+ return perrors.New("nacosRegistry is not
available.")
+ }
- for {
- if !nr.IsAvailable() {
- logger.Warnf("event listener game over.")
- return perrors.New("nacosRegistry is not available.")
- }
+ services, err := nr.getAllSubscribeServiceNames()
Review Comment:
This can be added later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
