[GitHub] [dubbo] veenter commented on a diff in pull request #13015: Fix ClassPool issue when multi-classloader

[via GitHub]

veenter commented on code in PR #13015:
URL: https://github.com/apache/dubbo/pull/13015#discussion_r1318474661


##########
dubbo-common/src/main/java/org/apache/dubbo/common/bytecode/Wrapper.java:
##########
@@ -158,7 +158,7 @@ private static Wrapper makeWrapper(Class<?> c) {
             pts.put(fn, ft);
         }
 
-        final ClassPool classPool = new ClassPool(ClassPool.getDefault());
+        final ClassPool classPool = new ClassPool(true);

Review Comment:
   确实是一样的。
   我目前的改法是出于最小修改原则
   如果要复用ClassGenerator的逻辑
   那么就是删除161 162 163这三行
   并替换为：final ClassPool classPool = ClassGenerator.getClassPool(cl);
   
   同时另外同时发现ClassGenerator.getClassPool这个方法没有做线程安全，也需要修改：
   
![image](https://github.com/apache/dubbo/assets/5327221/22ff1865-3f90-4858-aaa7-cca178ea2fd6)
   
   



##########
dubbo-common/src/main/java/org/apache/dubbo/common/bytecode/Wrapper.java:
##########
@@ -158,7 +158,7 @@ private static Wrapper makeWrapper(Class<?> c) {
             pts.put(fn, ft);
         }
 
-        final ClassPool classPool = new ClassPool(ClassPool.getDefault());
+        final ClassPool classPool = new ClassPool(true);

Review Comment:
   确实是一样的。
   我目前的改法是出于最小修改原则
   如果要复用ClassGenerator的逻辑
   那么就是删除161 162 163这三行
   并替换为：final ClassPool classPool = ClassGenerator.getClassPool(cl);
   
   同时另外同时发现ClassGenerator.getClassPool这个方法没有做线程安全，也需要修改：
   
![image](https://github.com/apache/dubbo/assets/5327221/22ff1865-3f90-4858-aaa7-cca178ea2fd6)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org