imhuzi commented on PR #13061: URL: https://github.com/apache/dubbo/pull/13061#issuecomment-1721031409
退订 On Fri, Sep 15, 2023 at 16:57 xuziheng ***@***.***> wrote: > What is the purpose of the change Brief changelog > > 为AbstractInvoker的destroyed字段添加volatile关键字，确保多线程的可见性。 > #13060 <https://github.com/apache/dubbo/issues/13060> > Verifying this change Checklist > > - Make sure there is a GitHub_issue > <https://github.com/apache/dubbo/issues> field for the change (usually > before you start working on it). Trivial changes like typos do not require > a GitHub issue. Your pull request should address just this issue, without > pulling in other changes - one PR resolves one issue. > - Each commit in the pull request should have a meaningful subject > line and body. > - Write a pull request description that is detailed enough to > understand what the pull request does, how, and why. > - Check if is necessary to patch to Dubbo 3 if you are work on Dubbo > 2.7 > - Write necessary unit-test to verify your logic correction, more mock > a little better when cross module dependency exist. If the new feature or > significant change is committed, please remember to add sample in dubbo > samples <https://github.com/apache/dubbo-samples> project. > - Add some description to dubbo-website > <https://github.com/apache/dubbo-website> project if you are > requesting to add a feature. > - GitHub Actions works fine on your own branch. > - If this contribution is large, please follow the Software Donation > Guide <https://github.com/apache/dubbo/wiki/Software-donation-guide>. > > ------------------------------ > You can view, comment on, or merge this pull request online at: > > https://github.com/apache/dubbo/pull/13061 > Commit Summary > > - f8ebfba > <https://github.com/apache/dubbo/pull/13061/commits/f8ebfba41fc79258495aad1153d177399d87f019> > Add volatile on destroyed filed ensure visibility > > File Changes > > (1 file <https://github.com/apache/dubbo/pull/13061/files>) > > - *M* > dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/protocol/AbstractInvoker.java > <https://github.com/apache/dubbo/pull/13061/files#diff-4681821b7f6b122431213007f59379e294c5fd0394794d435397f79cb4f2f84c> > (2) > > Patch Links: > > - https://github.com/apache/dubbo/pull/13061.patch > - https://github.com/apache/dubbo/pull/13061.diff > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/dubbo/pull/13061>, or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAF74AOBQV6ZRNH42JGETT3X2QKALANCNFSM6AAAAAA4ZPRTBI> > . > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
