EarthChen commented on code in PR #13155:
URL: https://github.com/apache/dubbo/pull/13155#discussion_r1349610675
##########
dubbo-common/src/main/java/org/apache/dubbo/rpc/model/ReflectionServiceDescriptor.java:
##########
@@ -74,6 +76,10 @@ private void initMethods() {
}
methods.forEach((methodName, methodList) -> {
+ //pb method not allow override
+ if(methodList.size() > 1 &&
methodList.stream().filter(methodDescriptor ->
Arrays.stream(methodDescriptor.getParameterClasses()).anyMatch(pclss ->
isProtobufClass(pclss))).count() > 0L){
Review Comment:
Please do not add complex judgments to if statements
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
