chickenlj commented on code in PR #2437:
URL: https://github.com/apache/dubbo-go/pull/2437#discussion_r1354306512
##########
registry/zookeeper/service_discovery.go:
##########
@@ -64,17 +64,18 @@ type zookeeperServiceDiscovery struct {
// newZookeeperServiceDiscovery the constructor of newZookeeperServiceDiscovery
func newZookeeperServiceDiscovery(url *common.URL) (registry.ServiceDiscovery,
error) {
+ rp := url.GetParam(constant.ZookeeperRootPath, rootPath)
Review Comment:
`RegistryConfig.group` is also designed for users to specify the root path.
So I think `ZookeeperRootPath = "zookeeper.rootPath"` is not necessary,
directly using `group` would be fine. Or at least we need to check `group` if
'rootPath' is not set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
