chickenlj commented on code in PR #2445:
URL: https://github.com/apache/dubbo-go/pull/2445#discussion_r1355972184
##########
protocol/triple/internal/server/cmd_instance_with_registry/main.go:
##########
@@ -31,11 +31,11 @@ func main() {
// configure global configurations and common modules
ins, err := dubbo.NewInstance(
dubbo.WithName("dubbo_test"),
- dubbo.WithRegistry("zk",
+ dubbo.WithRegistry(
registry.WithZookeeper(),
registry.WithAddress("127.0.0.1:2181"),
Review Comment:
Is 'registry.WithAddress("zookeeper://127.0.0.1:2181")' a valid method to
configure Registry, a combination of WithZookeeper() and
WithAddress("127.0.0.1:2181")? We should support this format if we want to give
a consistent experience to users familiar with Dubbo java.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
