DMwangnima commented on code in PR #2449:
URL: https://github.com/apache/dubbo-go/pull/2449#discussion_r1356748298
##########
client/options.go:
##########
@@ -414,12 +414,14 @@ func newDefaultCallOptions() *CallOptions {
}
}
+// WithCallRequestTimeout the maximum waiting time for one specific call, only
works for 'tri' and 'dubbo' protocol
func WithCallRequestTimeout(timeout string) CallOption {
Review Comment:
1. Should we modify **WithCallRequestTimeout** to
**WithCall_RequestTimeout** because there are **WithServer_XXX** options in
server module? Or just modify **WithServer_XXX** to **WithServerXXX** for
unification?
2. I forgot to modify the types of **WithCallRequestTimeout** and
**WithCallRetries**.
**WithCallRequestTimeout** should receive **time.Duration** and
**WithCallRetries** should receive **int**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
