finefuture commented on code in PR #13196: URL: https://github.com/apache/dubbo/pull/13196#discussion_r1360197782
########## dubbo-common/src/main/java/org/apache/dubbo/common/threadpool/serial/SerializingExecutor.java: ########## @@ -26,14 +26,13 @@ import org.apache.dubbo.common.threadlocal.InternalThreadLocalMap; import static org.apache.dubbo.common.constants.LoggerCodeConstants.COMMON_ERROR_RUN_THREAD_TASK; -import static org.apache.dubbo.common.utils.ExecutorUtil.isShutdown; /** * Executor ensuring that all {@link Runnable} tasks submitted are executed in order * using the provided {@link Executor}, and serially such that no two will ever be * running at the same time. */ -public final class SerializingExecutor implements Executor, Runnable { +public class SerializingExecutor implements Executor, Runnable { Review Comment: Ok, I will change it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org