zhengkaifor commented on code in PR #13137: URL: https://github.com/apache/dubbo/pull/13137#discussion_r1360381482
########## dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/event/listener/ServiceInstancesChangedListener.java: ########## @@ -159,7 +159,7 @@ private synchronized void doOnEvent(ServiceInstancesChangedEvent event) { .filter(Objects::nonNull) .filter(m -> revision.equals(m.getRevision())) .findFirst() - .orElseGet(() -> serviceDiscovery.getRemoteMetadata(revision, subInstances)); + .orElseGet(() -> getRemoteMetadata(revision, subInstances)); Review Comment: 之前是打算在这里重写MultiServiceInstancesChangedListener的getRemoteMetaData方法,来调整MultipleServiceDiscovery使用真正的ServiceDiscovery来获取元数据,目前调整成了直接重写MultipleServiceDiscovery. getRemoteMetadata 这里我还原一下 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org