FoghostCn commented on code in PR #2465:
URL: https://github.com/apache/dubbo-go/pull/2465#discussion_r1375216860
##########
config/metric_config.go:
##########
@@ -60,7 +59,7 @@ type PrometheusConfig struct {
}
type Exporter struct {
- Enabled *bool `default:"false" yaml:"enabled" json:"enabled,omitempty"
property:"enabled"`
+ Enabled *bool `default:"true" yaml:"enabled" json:"enabled,omitempty"
property:"enabled"`
Review Comment:
this will cause `url.getParam(constant.PrometheusExporterEnabledKey)`
allways true, means allways open http exporter of prometheus, see
https://github.com/apache/dubbo-go/blob/main/config/metric_config.go#L157
so we should keep it default false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
