Nortyr commented on code in PR #13238:
URL: https://github.com/apache/dubbo/pull/13238#discussion_r1381278027
##########
dubbo-metadata/dubbo-metadata-report-redis/src/main/java/org/apache/dubbo/metadata/store/redis/RedisMetadataReport.java:
##########
@@ -207,4 +226,261 @@ private String
getMetadataStandalone(BaseMetadataIdentifier metadataIdentifier)
}
}
+ @Override
+ public boolean registerServiceAppMapping(String serviceInterface, String
defaultMappingGroup, String newConfigContent, Object ticket) {
+ try {
+ if (null!= ticket && !(ticket instanceof String)) {
+ throw new IllegalArgumentException("zookeeper publishConfigCas
requires stat type ticket");
Review Comment:
Okay, I will fix it in this link:
https://github.com/apache/dubbo/pull/13303. Should I close this PR or that one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
