AlbumenJ commented on code in PR #13273:
URL: https://github.com/apache/dubbo/pull/13273#discussion_r1382383679
##########
dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/RegistryNotifier.java:
##########
@@ -68,7 +69,13 @@ public synchronized void notify(Object rawAddresses) {
// more than 10 calls && next execute time is in the future
boolean delay = shouldDelay.get() && delta < 0;
- if (delay) {
+ // when the scheduler is shutdown, no notification is sent
+ if (scheduler.isShutdown()) {
+ if (logger.isWarnEnabled()) {
+ logger.warn(COMMON_FAILED_NOTIFY_EVENT, "", "", "Notification
scheduler is off, no notifications are sent.");
Review Comment:
Also log the registry url
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
