xiaqi1210 commented on PR #2681: URL: https://github.com/apache/dubbo/pull/2681#issuecomment-1815941372
> ## What is the purpose of the change > Fix problem reported in [apache/skywalking#1769](https://github.com/apache/skywalking/issues/1769) > > ## Brief changelog > * Add Inject annotation > * Printing log instead of throwing Exception in SpringExtensionFactory > > ## Verifying this change > ExtensionLoaderTest.testInjectExtension > > Follow this checklist to help us incorporate your contribution quickly and easily: > > * [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. > * [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. > * [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. > * [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test). > * [x] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. > * [x] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).  I saw that the getExtension method call is inside a try...catch, so even if it throws an exception it shouldn't affect the overall SPI assembly right? But in actual testing I found it does affect the construction of the reference bean. When getting the reference bean, it gets null, which makes me confused. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
