Koooooo-7 commented on issue #13413: URL: https://github.com/apache/dubbo/issues/13413#issuecomment-1866119612
Hi @AlbumenJ , user only need run `mvn clean install` after they clone this repo as they usually do, that's all. I made a sample repo [git-hook-maven](https://github.com/Koooooo-7/git-hook-maven) as a PoC which you could have a look. Hi @SaptarshiSarkar12 , Although I raised this solution , it still looks little bit cumbersome to me tho. I still suggest that we just do those things only, for now. - Contribution guideline update about code format. - PR template reminds contributors need do code format. - CI actions add the formatting/linting check, if it were failed in format, showing the result and how to do format (in CI output) to contributors. If dubbo move to gradle soon, I suppose we could do the whole things by gradle at that time, instead of maintaining a weird `GitHook.java` in project. If it is not on the schedule, and you all agree with taking the plugin solution now, I'm also fine with it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
