chickenlj commented on code in PR #2548:
URL: https://github.com/apache/dubbo-go/pull/2548#discussion_r1437046494
##########
metadata/service/exporter/configurable/exporter.go:
##########
@@ -84,6 +85,22 @@ func (exporter *MetadataServiceExporter) Export(url
*common.URL) error {
return nil
}
+func getMetadataPort() string {
+ rootConfig := config.GetRootConfig()
+ port := rootConfig.Application.MetadataServicePort
+ if port == "" {
+ protocolConfig, ok :=
rootConfig.Protocols[constant.DefaultProtocol]
+ if ok {
+ port = protocolConfig.Port
+ } else {
+ logger.Warnf("[Metadata Service] Dubbo-go %s version's
MetadataService does not support triple protocol,"+
Review Comment:
The warning message would better be "[Metadata Service] Dubbo-go %s
version's MetadataService only support dubbo protocol, ". Because it might be
other protocols beyond dubbo and triple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
