CrazyHZM commented on code in PR #13593:
URL: https://github.com/apache/dubbo/pull/13593#discussion_r1439256988


##########
dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/MergeableClusterInvoker.java:
##########
@@ -93,7 +94,20 @@ protected Result doInvoke(Invocation invocation, 
List<Invoker<T>> invokers, Load
         for (final Invoker<T> invoker : invokers) {
             RpcInvocation subInvocation = new RpcInvocation(invocation, 
invoker);
             subInvocation.setAttachment(ASYNC_KEY, "true");
-            results.put(invoker.getUrl().getServiceKey(), 
invokeWithContext(invoker, subInvocation));
+            try {
+                results.put(invoker.getUrl().getServiceKey(), 
invokeWithContext(invoker, subInvocation));
+            } catch (RpcException e) {
+                if (e.isNoInvokerAvailableAfterFilter()) {
+                    log.warn(
+                            LoggerCodeConstants.CLUSTER_NO_VALID_PROVIDER,
+                            "",
+                            "",
+                            "No available provider for service" + 
getUrl().getServiceKey() + " on group "
+                                    + invoker.getUrl().getGroup() + ", will 
continue to try another group.");

Review Comment:
   Add the exception stack as well.
   @namelessssssssssss 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

Reply via email to