chickenlj commented on issue #2546: URL: https://github.com/apache/dubbo-go/issues/2546#issuecomment-1874781012
> If users pass Reference.RequestTimeout directly, getTimeout could retrieve attachTimeout successfully, but it does not overwrite the value corresponding to constant.TimeoutKey with the parsed timeout value. Yeah, we need to move `ivc.SetAttachment(constant.TimeoutKey, strconv.Itoa(int(timeout.Milliseconds())))` out of the else branch to make sure it always gets executed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
